[
https://issues.apache.org/jira/browse/AIRFLOW-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878558#comment-16878558
]
ASF GitHub Bot commented on AIRFLOW-4494:
-----------------------------------------
ashb commented on pull request #5273: [AIRFLOW-4494] Remove `shell=True` in
DaskExecutor
URL: https://github.com/apache/airflow/pull/5273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unwanted kwarg shell=True in DaskExecutor
> -----------------------------------------
>
> Key: AIRFLOW-4494
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4494
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
> Affects Versions: 1.10.3
> Reporter: GuoJiaqi
> Priority: Major
>
> This line:
> [https://github.com/apache/airflow/blob/master/airflow/executors/dask_executor.py#L68]
> If {{Popen}} is with {{shell=True}} and args is a list, the first item of
> list specifies the command string, the other items are the arguments of
> /bin/sh on POSIX.
> So the command {{airflow run ...}} will raise an error from dask-worker:
> {code:java}
> usage: airflow [-h]
> {backfill,list_dag_runs,list_tasks,clear,pause,unpause,trigger_dag,delete_dag,pool,variables,kerberos,render,run,initdb,list_dags,dag_state,task_failed_deps,task_state,serve_logs,test,webserver,resetdb,upgradedb,scheduler,worker,flower,version,connections,create_user,delete_user,list_users,sync_perm,next_execution,rotate_fernet_key}
> ...
> airflow: error: the following arguments are required: subcommand
> distributed.worker - WARNING - Compute Failed
> Function: airflow_run
> args: ()
> kwargs: {}
> Exception: CalledProcessError(2, ['airflow', 'run', 'tutorial', 'print_date',
> '2019-05-08T00:00:00+00:00', '--local', '-sd',
> '/Users/<me>/projects/dask_airflow/.venv/lib/python3.6/site-packages/airflow/example_dags/tutorial.py']){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
