ephraimbuddy commented on code in PR #28076:
URL: https://github.com/apache/airflow/pull/28076#discussion_r1045434699


##########
airflow/config_templates/config.yml:
##########
@@ -2377,7 +2377,7 @@
         failed worker pods will not be deleted so users can investigate them.
         This only prevents removal of worker pods where the worker itself 
failed,
         not when the task it ran failed.
-      version_added: 1.10.11
+      version_added: 2.5.0

Review Comment:
   I have been off for a while... @potiuk what do you think about this? I think 
the correctness depends on how one looks at it. The section/option is new in 
2.5.0 while the old section/option is not new. 
   
   If we mark it 1.10.11, users would think it'll work in 1.10.11 but that's 
not true. It will only work in 1.10.11 with the old section name, not the new 
one.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to