[
https://issues.apache.org/jira/browse/AIRFLOW-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878569#comment-16878569
]
ASF GitHub Bot commented on AIRFLOW-4895:
-----------------------------------------
tirkarthi commented on pull request #5533: [AIRFLOW-4895] Import Iterable from
collections.abc to fix DeprecationWarning in Python 3.7
URL: https://github.com/apache/airflow/pull/5533
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
### Description
Import Iterable from collections.abc to fix DeprecationWarning in Python
3.7. Use collections to ensure compatibility for Python 3.3 and below.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This fixes a DeprecationWarning and doesn't make code change
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> DeprecationWarning in Python 3.7 while running tests
> ----------------------------------------------------
>
> Key: AIRFLOW-4895
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4895
> Project: Apache Airflow
> Issue Type: Bug
> Components: ci
> Affects Versions: 2.0.0
> Environment: Ubuntu
> Reporter: Karthikeyan Singaravelan
> Assignee: Karthikeyan Singaravelan
> Priority: Trivial
>
> There is DeprecationWarning raised when running tests locally. This was
> introduced as part of AIRFLOW-3958 and commit
> 75bec88f04705884de58facaac97338a5b5b439a. This is similar to AIRFLOW-3009.
> Since the fix is simple enough I would like to work on this as my first
> contribution.
> DeprecationWarning in test
> {code:bash}
> /home/karthi/airflow/airflow/utils/helpers.py:26: DeprecationWarning: Using
> or importing the ABCs from 'collections' instead of from 'collections.abc' is
> deprecated, and in 3.8 it will stop working
> from collections import Iterable
> {code}
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
