[
https://issues.apache.org/jira/browse/AIRFLOW-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878628#comment-16878628
]
ASF GitHub Bot commented on AIRFLOW-4896:
-----------------------------------------
pgagnon commented on pull request #5534: [AIRFLOW-4896] Makes
KubernetesExecutorConfig's default args immutable
URL: https://github.com/apache/airflow/pull/5534
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
`KubernetesExecutorConfig`'s `labels` argument currently defaults to `{}`
which is a mutable value. Mutable default arguments are undesirable in python
since default arguments are evaluated at function definition time instead of at
call time.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Covered by existing tests.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
N/A
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> KubernetesExecutorConfig labels default argument is mutable
> -----------------------------------------------------------
>
> Key: AIRFLOW-4896
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4896
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
> Affects Versions: 2.0.0
> Reporter: Philippe Gagnon
> Assignee: Philippe Gagnon
> Priority: Minor
> Fix For: 2.0.0
>
>
> KubernetesExecutorConfig's {{labels}} default argument is mutable (empty
> dict).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
