ashb commented on code in PR #28322:
URL: https://github.com/apache/airflow/pull/28322#discussion_r1046944542
##########
dev/breeze/src/airflow_breeze/utils/kubernetes_utils.py:
##########
@@ -309,14 +309,10 @@ def _install_packages_in_k8s_virtualenv(with_constraints:
bool):
f"constraints-{sys.version_info.major}.{sys.version_info.minor}.txt",
]
)
- install_packages_result = run_command(
- install_command,
- check=False,
- capture_output=True,
- )
+ install_packages_result = run_command(install_command, check=False,
capture_output=True, text=True)
Review Comment:
Is there a reason `text=True` shouldn't be the default on all run_command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
