ashb commented on a change in pull request #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#discussion_r300401969
########## File path: tests/contrib/sensors/test_triggered_dagrun_sensor.py ########## @@ -0,0 +1,102 @@ +# -*- coding: utf-8 -*- +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +import os +from os.path import dirname, realpath +import unittest +from datetime import datetime + +from airflow.models import DagBag, TaskInstance, DagRun +from airflow.settings import Session +from airflow.utils.state import State +from airflow import configuration +from airflow.exceptions import AirflowException +from airflow.utils.timezone import convert_to_utc + +DEFAULT_DATE = convert_to_utc(datetime(2017, 1, 1)) +TEST_DAG_ID = 'test_triggered_dagrun_sensor_dag' +TEST_DAG_PARENT = TEST_DAG_ID + '_parent' +TEST_DAG_CHILD = TEST_DAG_ID + '_child' +TEST_DAG_FOLDER = os.path.join( + dirname(dirname(dirname(realpath(__file__)))), 'dags') + + +class TestTriggeredDagRunSensor(unittest.TestCase): + + def setUp(self): + configuration.load_test_config() + self.default_scheduler_args = { + "file_process_interval": 0, + "processor_poll_interval": 0.5, + "num_runs": 1 + } + self.dagbag = DagBag(dag_folder=TEST_DAG_FOLDER) + + def test_poke(self): + dag_parent = self.dagbag.get_dag(TEST_DAG_PARENT) + # dag_parent.run() + + # One of the following two runs should succeed, while the + # other should have its sensor time out. + + sess = Session() + TI = TaskInstance + # sensor_tis = sess.query(TI).filter( + # TI.dag_id == TEST_DAG_PARENT, + # TI.task_id == 'sense_child', + # TI.state == State.SUCCESS, + # ).all() + # self.assertEqual(len(sensor_tis), 1) + + # do_stuff_tis = sess.query(TI).filter( + # TI.dag_id == TEST_DAG_PARENT, + # TI.task_id == 'do_stuff', + # TI.state == State.SUCCESS, + # ).all() Review comment: Don't commit commented code please. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
