Taragolis commented on code in PR #28318:
URL: https://github.com/apache/airflow/pull/28318#discussion_r1049916675
##########
tests/providers/ftp/operators/test_ftp.py:
##########
@@ -184,3 +180,108 @@ def test_unequal_local_remote_file_paths(self):
local_filepath=["/tmp/test1", "/tmp/test2"],
remote_filepath="/tmp/test1",
)
+
+
+class TestFTPSFileTransmitOperator:
+ def setup_method(self):
+ self.test_local_dir = "/tmp"
+ self.test_local_dir_int = "/tmp/interdir"
+ self.test_remote_dir = "/ftpshome"
+ self.test_remote_dir_int = "/ftpshome/interdir"
+ self.test_local_filename = "test_local_file"
+ self.test_remote_filename = "test_remote_file"
+ self.test_local_filepath =
f"{self.test_local_dir}/{self.test_local_filename}"
+ self.test_remote_filepath =
f"{self.test_remote_dir}/{self.test_remote_filename}"
+ self.test_local_filepath_int_dir =
f"{self.test_local_dir_int}/{self.test_local_filename}"
+ self.test_remote_filepath_int_dir =
f"{self.test_remote_dir_int}/{self.test_remote_filename}"
+
+ def teardown_method(self):
+ if os.path.exists(self.test_local_dir_int):
+ os.rmdir(self.test_local_dir_int)
Review Comment:
Are files/directories created during test? If so better to use `pytest`'s
fixtures for that, rather than manually created them.
Depend of developer OS and configurations it might raise an errors as well
as add some side effects for other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
