pingzh commented on PR #28367: URL: https://github.com/apache/airflow/pull/28367#issuecomment-1353935068
@potiuk thanks for chiming me. I agree with that: > And rather than adding similarly named function to utils, it should have different name and signature to make it clear it is not similar to mkdirs behaviour. A better method name with very clear expectation is very important. as for the usage of this method, i was planning to update places that use ` Path(directory).mkdir(mode=0o777, parents=True, exist_ok=True) `. I should have called it out. as I don't want to make those changes, before we agree on the expected behavior of `mkdirs`. I noticed that while I was testing airflow 2 in Airbnb, but this method isn't directly used by our data pipelines) For example, the places that I plan to change is the https://github.com/apache/airflow/blob/b263dbcb0f84fd9029591d1447a7c843cb970f15/airflow/utils/log/file_task_handler.py#L324-L346 To me, the mode of `directory` has to be `0o777` otherwise other users cannot write logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
