potiuk commented on PR #28182: URL: https://github.com/apache/airflow/pull/28182#issuecomment-1356876053
> you don't think that, given that the work has already been done, it's more positive than negative to remove this constant, which ultimately is not really needed and is somewhat vague? Sorry missed that one as I did not realise it was for me, but I am catching up now after moving to a different country :). I just think it's a lot of code to add for such a simple thing. The way it is defined now explains it in the code pretty well (for maintainers) and the error message is very clear about it (for users). It serves the purpose pretty well. This is one line of code change rather than 40 lines of code added 10 removed here (net + 30 lines) That was my primary thinking by choosing "better". I usually do not think that something is "done" is a reason for its own to classify it as "better". Quite often my own "done code" is reworked, simplified and removed - sometime during the same PR, sometimes months or years later. And I am completely indifferent to the fact that it's "done". Because "done" is usually few percent of the effort needed for lifecycle of the code. I believe code is usually a liability that has to be maintained rather than asset. If it can be done in far less code - why not remove something that is done. If something serves the same purpose and is clear with far less code or no code at al - then for me it is "better". I actually love to remove my own code when possible while achieving same result. For me that means one less thing I have to maintain in the future (and that extrapolates to all the maintainers of Airflow). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
