jedcunningham commented on code in PR #28283:
URL: https://github.com/apache/airflow/pull/28283#discussion_r1052456738


##########
newsfragments/08212.misc.rst:
##########
@@ -0,0 +1 @@
+If you are using gevent for your webserver deployment and used local settigns 
to monkeypatch gevent, you might want to replace local settings patching with 
setting the ``_AIRFLOW_PATCH_GEVENT`` variable to 1 in your webserver.

Review Comment:
   ```suggestion
   If you are using gevent for your webserver deployment and used local 
settings to monkeypatch gevent, you might want to replace local settings 
patching with an ``_AIRFLOW_PATCH_GEVENT`` environment variable set to 1 in 
your webserver. This ensures gevent patching is done as early as possible.
   ```



##########
airflow/config_templates/config.yml:
##########
@@ -1222,7 +1222,9 @@
     - name: worker_class
       description: |
         The worker class gunicorn should use. Choices include
-        sync (default), eventlet, gevent
+        sync (default), eventlet, gevent. Note that in case of gevent you 
might also want to set

Review Comment:
   ```suggestion
           sync (default), eventlet, gevent. Note when using gevent you might 
also want to set the
   ```
   
   nit, just sounds better to my ear



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to