vincbeck commented on code in PR #28476:
URL: https://github.com/apache/airflow/pull/28476#discussion_r1053429692


##########
airflow/api_internal/endpoints/rpc_api_endpoint.py:
##########
@@ -68,7 +70,10 @@ def internal_airflow_api(
 
     log.debug("Calling method %.", {method_name})
     try:
-        output = handler(**params)
+        output = handler(
+            **params,
+            log=logging.getLogger(f"airflow.internal_api.{method_name}"),

Review Comment:
   Oh! That's a good point! I guess not. I dont think we should handle logs 
this way then. The simplest way would be to create a logger `log = 
logging.getLogger(__name__)` in `airflow/dag_processing/manager.py` and use 
this logger in static methods. The only downside is the logger would be the 
same whether or not internal API in turn on



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to