ashb commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1054261578
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -87,7 +149,14 @@ def close(self):
if self.handler:
self.handler.close()
- def _render_filename(self, ti: TaskInstance, try_number: int) -> str:
+ def _render_filename(
+ self,
+ ti: TaskInstance | TaskInstanceKey,
+ try_number: int,
+ *,
+ is_trigger=False,
+ ) -> str:
+ try_number = try_number + 1 if is_trigger else try_number
Review Comment:
Ugh :(. I'm not sure there is a better way of doing this (other than
entirely refactoring how try_number behaves which is a rather bigger issue than
this PR) but I don't like it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
