potiuk commented on code in PR #28459: URL: https://github.com/apache/airflow/pull/28459#discussion_r1054681194
########## tests/always/test_project_structure.py: ########## @@ -30,68 +30,79 @@ ) -class TestProjectStructure(unittest.TestCase): +class TestProjectStructure: Review Comment: Most of this module come from our past renaming we've doe in [AIP-21](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths) - and some of them can be removed or simplified or moved elsewhere as they never caught up as "common provider" approach: * test_deprecated_packages -> we should indeed remove, they are no problem any more * Test...ProviderProjectStructure - we should remove them - they bring no value and having then for few providers in here makes littel sense * ExampleCoverageTest - similarly * AssetsCoverageTest -> I think this is largely used by Google team. Naybe @bhirsz might tell more about it (though in any case I thik if it is useful for Google it should go to google provider tests. * test_providers_modules_should_have_tests -> is the only one I find useful from those for now but if it's broken, it might be we are far-off and fixing it would be problematic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
