dstandish commented on code in PR #28523: URL: https://github.com/apache/airflow/pull/28523#discussion_r1054687465
########## airflow/providers/cncf/kubernetes/triggers/wait_container.py: ########## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: **edit** this looks like random comment here but i was just replying to another reviewer's comment So the names are driven by what the things do. This is a trigger that waits until container done. It is used by KPO now, but it doesn't mean that something else couldn't use it. then, think about when you are reading KPO code if you see "now let's defer to wait container trigger" you know what it is doing if you see "now let's defer to kubernetes pod operator trigger", then you don't know quite as well what it's doing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
