kaxil commented on code in PR #28230:
URL: https://github.com/apache/airflow/pull/28230#discussion_r1054838589
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -484,15 +496,21 @@ def extract_xcom(self, pod: k8s.V1Pod):
return json.loads(result)
def execute(self, context: Context):
- remote_pod = None
+ """Based on the deferrable parameter runs the pod asynchronously or
synchronously"""
+ if self.deferrable:
+ self.asynchronously(context)
+ else:
+ return self.synchronously(context)
Review Comment:
Can you rename this too.
@VladaZakharova Apologies about delay in our contribution - Could you rebase
once https://github.com/apache/airflow/pull/28523 is merged. That PR also has
additional feature of ping-pong to show periodic logs which our customers found
very useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
