uranusjr commented on code in PR #27953:
URL: https://github.com/apache/airflow/pull/27953#discussion_r1055112051
##########
airflow/models/dag.py:
##########
@@ -3204,6 +3204,17 @@ def __init__(self, concurrency=None, **kwargs):
def __repr__(self):
return f"<DAG: {self.dag_id}>"
+ @property
+ def schedule_description(self) -> str | None:
+ if (
+ isinstance(self.schedule_interval, str)
+ and self.schedule_interval != "@once"
+ and self.timetable_description !=
DatasetTriggeredTimetable.description
+ ):
+ return str(self.schedule_interval) + " " + str(self.timezone.name)
Review Comment:
This weird isinstance check makes me feel the entire logic should go into
the timetable class instead. A timetable can decide whether it wants to take
`timezone`, and we can change `description` to include the timezone information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
