mhenc commented on code in PR #27892: URL: https://github.com/apache/airflow/pull/27892#discussion_r1055333764
########## airflow/api_internal/endpoints/rpc_api_endpoint.py: ########## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import json +import logging + +from flask import Response + +from airflow.api_connexion.types import APIResponse +from airflow.dag_processing.processor import DagFileProcessor +from airflow.serialization.serialized_objects import BaseSerialization + +log = logging.getLogger(__name__) + + +def _build_methods_map(list) -> dict: + return {f"{func.__module__}.{func.__name__}": func for func in list} + + +METHODS_MAP = _build_methods_map( + [ + DagFileProcessor.update_import_errors, + ] +) + + +def internal_airflow_api( + body: dict, +) -> APIResponse: + """Handler for Internal API /internal_api/v1/rpcapi endpoint.""" + log.debug("Got request") + json_rpc = body.get("jsonrpc") + if json_rpc != "2.0": + log.error("Not jsonrpc-2.0 request.") + return Response(response="Expected jsonrpc 2.0 request.", status=400) + + method_name = str(body.get("method")) + if method_name not in METHODS_MAP: + log.error("Unrecognized method: %s.", method_name) + return Response(response=f"Unrecognized method: {method_name}.", status=400) + + handler = METHODS_MAP[method_name] + params = {} + try: + if body.get("params"): + params_json = json.loads(str(body.get("params"))) + params = BaseSerialization.deserialize(params_json) + except Exception as err: + log.error("Error deserializing parameters.") + log.error(err) + return Response(response="Error deserializing parameters.", status=400) + + log.debug("Calling method %.", {method_name}) + try: + output = handler(**params) Review Comment: Right. I have an issue for that https://github.com/apache/airflow/issues/28267 The idea is: some components (like Scheduler/Webserver/Internal API) will always run these methods locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
