kaxil commented on PR #28230: URL: https://github.com/apache/airflow/pull/28230#issuecomment-1362785141
> > > > As we are adding new feature to existing operator instead of creating new operator for deferrable mode, we decided to also use KubernetesPodOperator as a base class for the GKEStartPodOperator to instantiate needed behavior. So splitting this to 2 separate PRs will be not an option here as we will also need to wait until KubernetesPodOperator will be merged to main and only then add new PR for the GKEStartPodOperator. Yup, that is exactly what I suggest, though. If the PRs are big, it will take more time for committers like myself to review and merge. If the PRs are broken down into smaller chunks it is easier to review and merge faster. What I would suggest: 1) Convert this PR to `Add "deferrable" mode to KPO`, and we will get this merged 2) Once (1) is merged, create a separate PR for adding deferrable mode to GKE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
