[
https://issues.apache.org/jira/browse/AIRFLOW-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879522#comment-16879522
]
ASF GitHub Bot commented on AIRFLOW-4904:
-----------------------------------------
mattrasto commented on pull request #5540: [AIRFLOW-4904] Retrieve test config
file from $AIRFLOW_TEST_CONFIG (default to home)
URL: https://github.com/apache/airflow/pull/5540
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-4904/) issues and
references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Add function to gather test config location from `$AIRFLOW_TEST_CONFIG` env
var.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Trivial change
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Retrieve test config from $AIRFLOW_TEST_CONFIG
> ----------------------------------------------
>
> Key: AIRFLOW-4904
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4904
> Project: Apache Airflow
> Issue Type: Improvement
> Components: configuration
> Affects Versions: 1.10.3
> Reporter: Matthew Rastovac
> Assignee: Matthew Rastovac
> Priority: Trivial
> Labels: newbie, pull-request-available
>
> There's an option to specify a specific location for the main config file via
> setting `$AIRFLOW_CONFIG`, but `unittests.cfg` is always appended (in an
> OS-unsafe way) to `$AIRFLOW_HOME`
> ([https://github.com/apache/airflow/blob/master/airflow/configuration.py#L505).]
>
> The `$AIRFLOW_TEST_CONFIG` var should allow for dynamic placement similar to
> how `$AIRFLOW_CONFIG` does.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
