dwreeves opened a new pull request, #28582:
URL: https://github.com/apache/airflow/pull/28582

   This PR is by request from @potiuk here: 
https://github.com/apache/airflow/pull/28505#discussion_r1053738869
   
   He wanted a succinct description of the breaking changes I introduced. I 
mention that JSON secrets for the AWS `SecretsManagerBackend` no longer do 
anything regarding urlencoding. I added a sub-bullet to clarify how this 
differs from the 5.x change, since at first glance they seem like they're 
indistinguishable changes.
   
   The changelog is meant to be very short and to the point. To keep things 
brief, I omitted two things:
   
   * I do _not_ mention the removal of `ast.literal_eval()` for `json.loads` 
because this was never a documented behavior, and a reasonable coder should 
have known better than to use invalid JSONs.
   * I also never mention that `get_conn_value()` can return a JSON because as 
of 6.1.0, the AWS provider package was already locked in base Airflow version 
`>=2.3.0` where this behavior is already assumed to be a supported (i.e. the 
base implementation for the method `get_connection()` calls `get_conn_value()`, 
and then checks whether it is a JSON or URL).
   
   ---
   
   I'm not sure exactly how you want this formatted so let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to