Taragolis commented on code in PR #28606:
URL: https://github.com/apache/airflow/pull/28606#discussion_r1057690939
##########
pytest.ini:
##########
@@ -19,8 +19,8 @@
addopts =
-rasl
--verbosity=2
-; This will treat all tests as flaky
-; --force-flaky
+ ; Disable `flaky` plugin for pytest. This plugin conflicts with
`rerunfailures` because provide same marker.
+ -p no:flaky
Review Comment:
Yeah, out dev dependencies already depend on `pytest-rerunfailures`
https://github.com/apache/airflow/blob/4e545c6e54712eedb6ca9cbb8333393ae3f6cba2/setup.py#L402-L404
I do not know how we use this plugin before - it just sits in our
dev-requirements, the same with `flaky` it is only used for couple tests, which
can replaced by `pytest-rerunfailures`
There is maybe another good question: should we specify explicitly specify
all plugins which we actually use? But this only help to fail fast if plugin
not installed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
