dstandish commented on code in PR #28288:
URL: https://github.com/apache/airflow/pull/28288#discussion_r1057897984
##########
airflow/executors/local_kubernetes_executor.py:
##########
@@ -43,6 +43,8 @@ class LocalKubernetesExecutor(LoggingMixin):
KUBERNETES_QUEUE = conf.get("local_kubernetes_executor",
"kubernetes_queue")
+ is_local: bool = False
Review Comment:
Yeah i mean, the flag itself is problematic. Because, with these composite
executors, it's not yes or no.
Is it local? well, yes and no -- depends what you need, depends why you are
asking. So this flag should probably be replaced with something more specific
to what it's actually concerned about. Iike, the specific behavior that is
required / investigated and not whether the executor is "a local executor".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
