Taragolis commented on code in PR #28569:
URL: https://github.com/apache/airflow/pull/28569#discussion_r1058237022
##########
airflow/providers/slack/provider.yaml:
##########
@@ -39,7 +39,7 @@ versions:
- 1.0.0
dependencies:
- - apache-airflow>=2.3.0
+ - apache-airflow>=2.6.0.dev0
Review Comment:
I think this lines in
`airflow/providers/slack/notifications/slack_notifier.py` would be enough, so
we keep all other feature compatible with 2.3, and notifiers will work only
with 2.6 and user get an error if try to use it in old version
```python
from airflow.exceptions import AirflowOptionalProviderFeatureException
try:
from airflow.notifications.basenotifier import BaseNotifier
except ImportError as e:
raise AirflowOptionalProviderFeatureException(e)
```
@potiuk correct me if I wrong. Because
`AirflowOptionalProviderFeatureException` it it quite new feature - only work
with Airflow 2.3+ , and we just drop support 2.2 for providers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
