blag commented on issue #28280: URL: https://github.com/apache/airflow/issues/28280#issuecomment-1366839468
TIL. What an odd choice. While there are many tools that will happily deal with all of the different forms of newlines, sadly some tools that remain in popular usage still do not gracefully handle unexpected newline characters. I ran into this issue when I was "going off the beaten path" a bit - I'm storing an SSH key in an Airflow variable and writing it to a file before passing it to `ssh` (the SSH operator does not fit this particular use case). Given that, I think it really boils down to how strange of use cases we want to directly support. Allowing users to normalize variables on read would solve the problem, but simply piping values through `dos2unix` solves the problem as well, and I would expect that practically every tool that doesn't handle non-normalized newlines would be run directly via the BashOperator. As inconsistent as all of this is, unless there's a more typical use case for normalizing variable text, I don't think we need to change anything in Airflow itself. And since the issue is far removed from Airflow as well, I don't even know if Airflow would be an appropriate place to document this. Thank you both for your attention, but since there's nothing to really fix, I'm going to close this issue. It can be reopened or duplicated if somebody else runs into this issue and has a more typical use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
