Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058601195
########## tests/providers/conftest.py: ########## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import pytest + +from tests.test_utils import db + +# Providers with subpackages +INNER_PROVIDERS = { Review Comment: > I hate having to wait even 0.5 s to run single test with Ctrl+R. Plus some people have auto-rerrunable tests (there are plugins that run tests automatically after saving). We cannot make that experience so much worse. This could be nice debate for many reason. First of all `pytest` itself started for about 1 second with load all plugins plus outputs might take a lot of resources. ```console ❯ time pytest --help ... pytest --help 1.21s user 0.21s system 76% cpu 1.851 total ❯ time pytest --help ... pytest --help 0.58s user 0.11s system 98% cpu 0.697 total ❯ time pytest --help ... pytest --help 0.59s user 0.12s system 87% cpu 0.816 total ``` PyCharm also could add latency. Hopefully we not enable any coverage in adopts because PyCharm/IDEA could add additional 5-10 seconds per run in this case. Personally most of the time I spend in debugger when I try to check is it work as expected or try to figure out why it not working. And usually rerun all the module tests just for sure that last change not break anything new. As well as if we consider **X** it is a time for create something new then time for cover by tests plus fixing become **X * 5** with most of the time siting with hand on the face and told "Why on Earth you don't work as expected" or "This concept is garbage I need to rewrite my code because tests shows me not everything might work well". But this is a personal as well as all times only related to my setup, someone who has old laptop could additionally wait more than 0.2 second -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
