moiseenkov commented on code in PR #28336:
URL: https://github.com/apache/airflow/pull/28336#discussion_r1059410960
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,7 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param logs_timeout: timeout in seconds to read logs after container
termination.
Review Comment:
@dstandish, thank you for noting that. Actually, I agree that exposing this
parameter isn't a good idea - it handles logic that doesn't belong to the
operator's level of abstraction and we will have to maintain it. At the same
time I'm sure that it's better to leave the ability for configuring it because
updates of third-party libraries can change the system's behavior and users
would be able to adjust this parameter and stop suffering.
As a compromise, could we consider a different approach based on envs or
maybe something else? I didn't find any recommendations regarding envs in the
contribution manuals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
