vemikhaylov commented on code in PR #28667:
URL: https://github.com/apache/airflow/pull/28667#discussion_r1059803154


##########
airflow/example_dags/example_passing_params_via_test_command.py:
##########
@@ -30,18 +30,15 @@
 
 
 @task(task_id="run_this")
-def my_py_command(params, test_mode=None, task=None):

Review Comment:
   It wasn't clear to me if a specific case was intended to be tested here 
originally with the usage of the `params` name here, which is also a name of 
the `task.params` attribute or it's just a coincidence.
   
   I moved it to a simpler structure. If the original one made sense and is 
needed as well, please let me know, I'll restore it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to