uranusjr commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1061221018
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -187,8 +188,18 @@ def _group_logs_by_host(self, logs):
def _read_grouped_logs(self):
return True
+ @cached_property
+ def supports_triggerer(self):
+ """Not implemented yet."""
+ return False
Review Comment:
So to sum up
1. Mypy complains if we make this a class var in the parent class but
property in children
2. We need this to be a property in children because some of those need
runtime evaluation
In that case I guess a property is alright. I wish Mypy can improve on this;
it’s actually a quite common pattern. (To achieve this we need a way to declare
an _attribute_ as read-only, I digress…)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
