kacpermuda opened a new pull request, #28735:
URL: https://github.com/apache/airflow/pull/28735

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   Google Campaign Manager 360, in their latest api version (v4), introduced a 
new status that a report file can return. As v4 is the only version that is 
currently supported, we should update the sensor to work well with these 
changes.
   
   Currently, sensor only checks if file status is different from `PROCESSING`. 
As You can see in the official 
[documentation](https://developers.google.com/doubleclick-advertisers/rest/v4/File#status)
 there is a status called `QUEUED` which also means that the report file is not 
yet picked up for processing. From my experience this status can be returned 
when API is globally under heavy load or if You are generating multiple reports 
at once as a single user. Right now sensor exits when finding QUEUED status: 
   <img width="438" alt="image" 
src="https://user-images.githubusercontent.com/79157078/210618385-5f284e9a-93b2-45ef-818d-ac9db8e9b7a0.png";>
   and it should wait for the file to be processed.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to