yxiao1996 commented on code in PR #28686:
URL: https://github.com/apache/airflow/pull/28686#discussion_r1062839814


##########
airflow/www/static/js/gantt.js:
##########
@@ -212,12 +229,23 @@ d3.gantt = () => {
           mapIndex: d.map_index,
         });
       })
-      .attr('class', (d) => d.state || 'null')
+      .attr('class', (d) => `${d.state || 'null'} all-tasks`)
       .attr('y', 0)
       .attr('transform', rectTransform)
       .attr('height', () => y.rangeBand())
       .attr('width', (d) => d3.max([x(d.end_date.valueOf()) - 
x(d.start_date.valueOf()), 1]));
 
+    svg.selectAll('.chart')

Review Comment:
   sounds good, will add comment here to mark the line painting all instances 
vs. instance queued states. also will add similar comments in redraw method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to