wolfier opened a new issue, #28756:
URL: https://github.com/apache/airflow/issues/28756

   ### Apache Airflow version
   
   2.5.0
   
   ### What happened
   
   In [Airflow 
2.4.0](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst#airflow-240-2022-09-19),
 a new feature was added that added an option to mask sensitive data in UI 
configuration page ([PR](https://github.com/apache/airflow/pull/25346)). I have 
set `AIRFLOW__WEBSERVER__EXPOSE_CONFIG` as `NON-SENSITIVE-ONLY`.
   
   The feature is working partially as the `airflow.cfg` file display only has 
[sensitive 
configurations](https://github.com/apache/airflow/blob/2.5.0/airflow/configuration.py#L149-L160)
 marked as `< hidden >`. However, the `Running Configuration` table below the 
file display has all configuration set via environment variables marked as `< 
hidden >` which I believe is unintended.
   
   I did not change `airflow.cfg` so the value here is displaying the default 
value of `False` as expected.
   
   ![Screen Shot 2023-01-05 at 1 39 11 
PM](https://user-images.githubusercontent.com/5952735/210891805-1a5f6a6b-1afe-4d05-b03d-61ac583441fc.png)
   
   The value for `expose_config` I expect to be shown as `NON-SENSITIVE-ONLY` 
but it shown as `< hidden >`.
   
   ![Screen Shot 2023-01-05 at 1 39 27 
PM](https://user-images.githubusercontent.com/5952735/210891803-dba826d4-2d3c-4781-aeae-43c46e31fa89.png)
   
   
   ### What you think should happen instead
   
   As mentioned previously, the value for `expose_config` I expect to be shown 
as `NON-SENSITIVE-ONLY`.
   
   Only the [sensitive 
variables](https://github.com/apache/airflow/blob/2.5.0/airflow/configuration.py#L149-L160)
 should be set as `< hidden >`.
   
   ### How to reproduce
   
   Set an Airflow configuration through the environment variable and check on 
the Configuration page.
   
   ### Operating System
   
   n/a
   
   ### Versions of Apache Airflow Providers
   
   n/a
   
   ### Deployment
   
   Astronomer
   
   ### Deployment details
   
   n/a
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to