uranusjr commented on code in PR #28097:
URL: https://github.com/apache/airflow/pull/28097#discussion_r1063093904
##########
airflow/sensors/external_task.py:
##########
@@ -143,18 +143,27 @@ def __init__(
if external_task_id is not None and external_task_ids is not None:
raise ValueError(
"Only one of `external_task_id` or `external_task_ids` may "
- "be provided to ExternalTaskSensor; not both."
+ "be provided to ExternalTaskSensor; "
+ "Use external_task_id or external_task_ids or
external_task_group_id."
Review Comment:
```suggestion
"be provided to ExternalTaskSensor; "
"use external_task_id or external_task_ids or
external_task_group_id."
```
Same for other messages below. Or you could use a period instead.
##########
airflow/sensors/external_task.py:
##########
@@ -217,6 +226,13 @@ def poke(self, context, session=None):
serialized_dttm_filter,
)
+ if self.external_dag_id and not self.external_task_group_id and not
self.external_task_ids:
+ self.log.info(
+ "Poking for dag '%s' on %s ... ",
Review Comment:
```suggestion
"Poking for DAG '%s' on %s ... ",
```
I wonder if this message could be spammy? This would appear again and again
until the poke is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
