potiuk commented on code in PR #28528:
URL: https://github.com/apache/airflow/pull/28528#discussion_r1063210989
##########
airflow/ti_deps/deps/ready_to_reschedule.py:
##########
@@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context):
from airflow.models.mappedoperator import MappedOperator
is_mapped = isinstance(ti.task, MappedOperator)
- if not is_mapped and not getattr(ti.task, "reschedule", False):
+ is_debug_executor = conf.get("core", "executor") == "DebugExecutor"
Review Comment:
> @potiuk this is covered by the single threaded case actually, which is
more precisely what the issue is. Any single threaded executor needs to
reschedule sensors otherwise the thread will be blocked when the sensor sleeps.
Yep. You are right. Single-threaded is the right check here and we should
use it here. I think being single-threaded is the only reason we are doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
