feluelle commented on PR #28710:
URL: https://github.com/apache/airflow/pull/28710#issuecomment-1373638571
> sure you could use param class and add an ID but that is a lot more noise.
Not to me, but okay.
Instead of
```python
# full key
# no conn - no bucket - full key
(None, {"key": "s3://key_bucket/key.txt"}, ["key_bucket", "key.txt"]),
```
you would do:
```python
param(None, {"key": "s3://key_bucket/key.txt"}, ["key_bucket", "key.txt"],
id="unify-no_conn-no_bucket-full_key"),
```
and you get more descriptive output in pytest.
> and it risks that the params differ from the description (id).
Isn't this the same as with comments (we have above each line)? And comments
also can be valuable. You just need to make sure to update them accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
