[GitHub] [airflow] uranusjr commented on a diff in pull request #28764: Add support for running a Beam Go pipeline with an executable binary

Sun, 08 Jan 2023 23:51:11 -0800 


uranusjr commented on code in PR #28764:
URL: https://github.com/apache/airflow/pull/28764#discussion_r1064353800


##########
airflow/providers/apache/beam/operators/beam.py:
##########
@@ -563,8 +582,13 @@ def __init__(
             )
         self.dataflow_support_impersonation = False
 
+        if not bool(go_file) ^ bool(go_binary):

Review Comment:
   But this check likely also needs to include `worker_binary`? Right now it’s 
possible to pass in `go_binary` without `worker_binary`, which would cause a 
weird error in the worker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to