snjypl commented on code in PR #28638:
URL: https://github.com/apache/airflow/pull/28638#discussion_r1065176714
##########
airflow/executors/local_kubernetes_executor.py:
##########
@@ -48,6 +48,8 @@ class LocalKubernetesExecutor(LoggingMixin):
is_local: bool = False
+ serve_logs: bool = True
Review Comment:
> You'll need to add a default for the `CeleryKubernetesExecutor` as well
(with False being the value I reckon), since that class does not inherit
(directly) from BaseExecutor (see [this
comment](https://github.com/apache/airflow/issues/28276#issuecomment-1344899475)
for more details).
should we do `hasattr(executor.serve_logs)` to be sure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
