potiuk commented on code in PR #28820: URL: https://github.com/apache/airflow/pull/28820#discussion_r1065415994
########## airflow/providers/arangodb/hooks/arangodb.py: ########## @@ -18,14 +18,20 @@ """This module allows connecting to a ArangoDB.""" from __future__ import annotations -from typing import Any +from typing import TYPE_CHECKING, Any from arango import AQLQueryExecuteError, ArangoClient as ArangoDBClient -from arango.result import Result from airflow import AirflowException +from airflow.compat.functools import cached_property from airflow.hooks.base import BaseHook +if TYPE_CHECKING: Review Comment: BTW. Why do we want to add "if TYPE_CHECKING" here @Taragolis ? I was under the impression that we use if TYPE_CHECKING only when we cannot do it otherwise because of importing circular references but I think in this case it is not needed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
