potiuk commented on PR #28822:
URL: https://github.com/apache/airflow/pull/28822#issuecomment-1378085890
I think this is one of those cases that we really balloon a matrix of tests
for very little reason.
Seems that we alrady have a number of tests - now failing) where both are
set - yet we still do not have the combo right.
After seeing the number of tests failing, though, I have a second thought -
because apparently this combo was actually quite thoroughly tested before.
I wonder (for my own understanding here) - why the (currently failing) tests
were added. What was the reasoning behind having a number of `"gitSync":
{"enabled": True}, "persistence": {"enabled": True}` in the parameterized tests?
Was there any other thought behind it that we knew or expected this combo to
be working or was it just - ok let's test all the combinations without much of
a thinking whether this combo is actually useful?
I think answer to that should determine whether it makes sense to remove it
completely or maybe just warn the users and try to fix the cases we know for
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
