uranusjr commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066629079
########## airflow/api_internal/endpoints/rpc_api_endpoint.py: ########## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.processor import DagFileProcessor +from airflow.models.dag import DagModel Review Comment: I still don’t like both `airflow.models` and `airflow.api_internal` import each other, although _technically_ the imports are not circular. Wrap `METHODS_MAP` in a function with local imports should be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
