[GitHub] [airflow] uranusjr commented on a diff in pull request #28848: Use default connection id for KubernetesPodOperator

Wed, 11 Jan 2023 00:21:33 -0800 


uranusjr commented on code in PR #28848:
URL: https://github.com/apache/airflow/pull/28848#discussion_r1066693582


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -229,7 +229,7 @@ class KubernetesPodOperator(BaseOperator):
     def __init__(
         self,
         *,
-        kubernetes_conn_id: str | None = None,  # 'kubernetes_default',
+        kubernetes_conn_id: str = "kubernetes_default",

Review Comment:
   Actually, it’s probably better to use `KubernetesHook.default_conn_name` as 
the default instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to