Taragolis commented on code in PR #28850:
URL: https://github.com/apache/airflow/pull/28850#discussion_r1066843322


##########
airflow/providers/amazon/provider.yaml:
##########
@@ -52,6 +52,7 @@ dependencies:
   - apache-airflow>=2.3.0
   - apache-airflow-providers-common-sql>=1.3.1
   - boto3>=1.24.0
+  - aiobotocore>=2.1.1

Review Comment:
   I think add this as core dependency for amazon-provider could broke some 
existed functionality.
   At least until `aiobotocore` resolve this issue 
https://github.com/aio-libs/aiobotocore/issues/976 and remove upper bound of 
[`botocore`](https://github.com/aio-libs/aiobotocore/blob/14b2f5fe0033a1f4bbc456f10633c2aeea74f57a/setup.py#L10).
   
   Because `botocore` is a main package for `boto3` and if we can't upgrade 
both of them we can't add new features which introduced since `botocore` 1.28.0+
   
   Changelogs: 
   - [botocore](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst)
   - [boto3](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to