jedcunningham commented on code in PR #28808:
URL: https://github.com/apache/airflow/pull/28808#discussion_r1067376758
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -272,6 +273,7 @@ def __init__(
pod_runtime_info_envs: list[k8s.V1EnvVar] | None = None,
termination_grace_period: int | None = None,
configmaps: list[str] | None = None,
+ base_container_name: str = "base",
Review Comment:
That's basically what I'm saying. The "how" (default of none vs the
constant) doesn't really matter at the end of the day, they are functionally
equivalent:
```
BASE_CONTAINER_NAME = "base"
...
base_container_name: str = BASE_CONTAINER_NAME
...
self.base_container_name = base_container_name
```
and
```
BASE_CONTAINER_NAME = "base"
...
base_container_name: str | None = None
...
self.base_container_name = base_container_name or BASE_CONTAINER_NAME
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
