uranusjr commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-1380049884
I’m pondering what the correct fix is here. `KEY_REGEX` (and `GROUP_KEY_REGEX`) allowing non-ASCII characters is arguably unintended, since those regex patterns are from way back since Python 2, when `re.ASCII` was the default. `\w` allowing non-ASCII (Unicode mode) was only default on Python 3. So we could potentially declare the current behaviour as a bug, and simply add `re.ASCII` to those patterns and break any DAGs using non-ASCII IDs. But on the other hand, I do sympathise users already using non-ASCII charahcters, and it may also be viable to _only disallow non-ASCII when statsd is enabled_. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
