Skip to site navigation (Press enter)

[GitHub] [airflow] IAL32 opened a new issue, #28888: `webserver.instance_name` shows markup text in `` tag</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=commits@airflow.apache.org&q=from:%22GitBox%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">GitBox</span></span></a></span> <span class="date"><a href="/search?l=commits@airflow.apache.org&q=date:20230112" rel="nofollow">Thu, 12 Jan 2023 06:33:02 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody">  <pre> IAL32 opened a new issue, #28888: URL: <a rel="nofollow" href="https://github.com/apache/airflow/issues/28888">https://github.com/apache/airflow/issues/28888</a></pre><pre> ### Apache Airflow version 2.5.0 ### What happened <a rel="nofollow" href="https://github.com/apache/airflow/pull/20888">https://github.com/apache/airflow/pull/20888</a> enables the use of markup to style the `webserver.instance_name`. However, if the instance name has HTML code, this will also be reflected in the `<title>` tag, as shown in the screenshot below. ![image](<a rel="nofollow" href="https://user-images.githubusercontent.com/562969/212091882-d33bb0f7-75c2-4c92-bd4f-4bc7ba6be8db.png">https://user-images.githubusercontent.com/562969/212091882-d33bb0f7-75c2-4c92-bd4f-4bc7ba6be8db.png</a>) This is not a pretty behaviour. ### What you think should happen instead Ideally, if `webserver. instance_name_has_markup = True`, then the text inside the `<title>` should be stripped of HTML code. For example: - Set `webserver.instance_name` to some text with markup, like `<b style="color: red">title</b>` - Set `webserver.Instance_name_has_markup` to `true` This is how the `<title>` tag should look like: ```html <title>DAGs - title</title> ``` Instead of: ``` <title>DAGs - <b style="color: red">title<b></title> ``` ### How to reproduce - Airflow version 2.3+, which is [when this change has been introduced](<a rel="nofollow" href="https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#instance-name-has-markup">https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#instance-name-has-markup</a>) - Set `webserver.instance_name` to some text with markup, like `<b style="color: red">title</b>` - Set `webserver.Instance_name_has_markup` to `true` ### Operating System Doesn't matter ### Versions of Apache Airflow Providers _No response_ ### Deployment Other ### Deployment details _No response_ ### Anything else _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](<a rel="nofollow" href="https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md">https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md</a>) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg259379.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd4.html#259380">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="mail5.html#259380">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg259381.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email tSliceCur"><span class="subject">[GitHub] [airflow] IAL32 opened a new issue, #28888: `webserver.ins...</span> <span class="sender italic">GitBox</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg259381.html">[GitHub] [airflow] boring-cyborg[bot] commented on issue #2888...</a></span> <span class="sender italic">GitBox</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[GitHub] [airflow] IAL32 opened a new issue, #28888: `webserver.instance_name` shows markup text in `<title>` tag"> <input type="hidden" name="msgid" value="I_kwDOAgUK285bPm-H@gitbox.apache.org"> <input type="hidden" name="relpath" value="commits@airflow.apache.org/msg259380.html"> <input type="submit" value=" GitBox "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="commits@airflow.apache.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search commits"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/commits@airflow.apache.org/">commits - all messages</a></li> <li class="icons-about"><a href="/commits@airflow.apache.org/info.html">commits - about the list</a></li> <li class="icons-expand"><a href="/search?l=commits@airflow.apache.org&q=subject:%22%5C%5BGitHub%5C%5D+%5C%5Bairflow%5C%5D+IAL32+opened+a+new+issue%2C+%2328888%5C%3A+%60webserver.instance_name%60+shows+markup+text+in+%60%3Ctitle%3E%60+tag%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg259379.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg259381.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">I_kwDOAgUK285bPm-H@gitbox.apache.org</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9d4867bf8cd748fc',t:'MTc3MjIwMjg5MA=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>