dstandish commented on code in PR #28871:
URL: https://github.com/apache/airflow/pull/28871#discussion_r1068629030
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -763,13 +763,14 @@ def _change_state(self, key: TaskInstanceKey, state: str
| None, pod_id: str, na
self.kube_scheduler.patch_pod_executor_done(pod_id=pod_id,
namespace=namespace)
self.log.info("Patched pod %s in namespace %s to mark it as done",
str(key), str(namespace))
- if key in self.running:
+ try:
self.running.remove(key)
- # We do get multiple events once the pod hits a terminal state,
and we only want to
+ except KeyError:
+ self.log.debug("TI key not in running, not adding to event_buffer:
%s", key)
+ else:
+ # We get multiple events once the pod hits a terminal state, and
we only want to
Review Comment:
i think this changes the behavior
if no error (key is in running) else will be entered
previously, if key is in running, we do not hit else. is that desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
