o-nikolas commented on code in PR #28897: URL: https://github.com/apache/airflow/pull/28897#discussion_r1068648627
########## tests/cli/commands/test_standalone_command.py: ########## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from unittest import mock + +import pytest + +from airflow.cli.commands.standalone_command import StandaloneCommand +from airflow.executors.executor_constants import ( + CELERY_EXECUTOR, + CELERY_KUBERNETES_EXECUTOR, + DASK_EXECUTOR, + DEBUG_EXECUTOR, + KUBERNETES_EXECUTOR, + LOCAL_EXECUTOR, + LOCAL_KUBERNETES_EXECUTOR, + SEQUENTIAL_EXECUTOR, +) + + +class TestStandaloneCommand: + @pytest.mark.parametrize( + "conf_executor_name, conf_sql_alchemy_conn, expected_standalone_executor", + [ + (LOCAL_EXECUTOR, "sqlite_conn_string", LOCAL_EXECUTOR), Review Comment: This actually raises an interesting edge case. This being a local executor allows it to not fall into that if branch, but we'd actually want to force to the sequential executor in this case (since sqlite is the db). This isn't anything wrong with your PR, and we should likely merge it as is. But we may want to revisit this in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
