josh-fell commented on PR #28842: URL: https://github.com/apache/airflow/pull/28842#issuecomment-1382023560
> Hmmmm, so the advantage of keeping it behind TYPE_CHECKING is that it's one less import at runtime. > > In practice this will already be imported, but still, it's an import we don't need to do, so I'd say we keep the TYPE_CHECKING if the only reason for the import is a type annotation That's a very valid point and thinking about it, I agree. Not sure why it didn't cross my mind. Been out of practice from the last 3 months of leave. But, you have inspired another idea. I'll close this monster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
