[
https://issues.apache.org/jira/browse/AIRFLOW-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882495#comment-16882495
]
ASF GitHub Bot commented on AIRFLOW-4928:
-----------------------------------------
serkef commented on pull request #5557: [AIRFLOW-4928] Move all config parses
to class properties
URL: https://github.com/apache/airflow/pull/5557
Make sure you have checked _all_ steps below.
### Jira
- [x ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-4928
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Every `airflow.configuration.conf` method is being called multiple times. We
can avoid redundant evaluation by storing the parsed value in the class
namespace.
### Tests
- [ x ] My PR does not need testing for this extremely good reason:
Is already covered. No new features are implemented.
### Commits
- [ x ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ x ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove redundant config parsing in DagBag
> ------------------------------------------
>
> Key: AIRFLOW-4928
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4928
> Project: Apache Airflow
> Issue Type: Improvement
> Components: models
> Affects Versions: 1.10.3
> Reporter: Sergio Kef
> Assignee: Sergio Kef
> Priority: Minor
> Labels: easyfix
>
> In DagBag, configuration file is parsed multiple times while this can be
> avoided. We can save the values we read in the object namespace and refer it
> within the instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
