igorborgest commented on code in PR #28869:
URL: https://github.com/apache/airflow/pull/28869#discussion_r1070118130
##########
airflow/providers/amazon/aws/operators/appflow.py:
##########
@@ -93,6 +98,12 @@ def execute(self, context: Context) -> None:
self.connector_type = self._get_connector_type()
if self.flow_update:
self._update_flow()
+ # previous code had a wait between update and run without
explaining why.
+ # since I don't have a way to actually test this behavior,
+ # I'm reproducing it out of fear of breaking workflows.
+ # It might be unnecessary.
Review Comment:
If I recall correctly, the updates are not propagated atomically. So this
sleep was to avoid runs using the previous configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
