arjunanan6 commented on PR #28394: URL: https://github.com/apache/airflow/pull/28394#issuecomment-1382697955
@snjypl Just got time now... I can't run your patch though, it fails to build: ``` #10 0.625 patching file airflow/utils/log/file_task_handler.py #10 0.625 Hunk #1 FAILED at 215. #10 0.625 1 out of 1 hunk FAILED -- saving rejects to file /tmp/rejects #10 0.632 patching file airflow/utils/log/file_task_handler.py #10 0.632 Hunk #1 FAILED at 215. #10 0.633 1 out of 1 hunk FAILED -- saving rejects to file /tmp/rejects #10 0.634 --- airflow/utils/log/file_task_handler.py #10 0.634 +++ airflow/utils/log/file_task_handler.py #10 0.634 @@ -215,7 +215,7 @@ def _read(self, ti: TaskInstance, try_number: int, metadata: dict[str, Any] | No #10 0.634 selector = PodGenerator.build_selector_for_k8s_executor_pod( #10 0.634 dag_id=ti.dag_id, #10 0.634 task_id=ti.task_id, #10 0.634 - try_number=ti.try_number, #10 0.634 + try_number=try_number, #10 0.634 map_index=ti.map_index, #10 0.634 run_id=ti.run_id, #10 0.634 airflow_worker=ti.queued_by_job_id, #10 0.634 --- airflow/utils/log/file_task_handler.py #10 0.634 +++ airflow/utils/log/file_task_handler.py #10 0.634 @@ -215,7 +215,7 @@ def _read(self, ti: TaskInstance, try_number: int, metadata: dict[str, Any] | No #10 0.634 selector = PodGenerator.build_selector_for_k8s_executor_pod( #10 0.634 dag_id=ti.dag_id, #10 0.634 task_id=ti.task_id, #10 0.634 - try_number=try_number, #10 0.634 + try_number=ti.try_number, #10 0.634 map_index=ti.map_index, #10 0.634 run_id=ti.run_id, #10 0.634 airflow_worker=ti.queued_by_job_id, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
